[
https://issues.apache.org/jira/browse/CB-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554569#comment-14554569
]
ASF GitHub Bot commented on CB-9051:
------------------------------------
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/223#discussion_r30817164
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -122,6 +122,12 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
if (platformAlreadyAdded) {
throw new CordovaError('Platform ' + platform
+ ' already added.');
}
+
+ // Remove the <platform>.json file from the
plugins directory, so we start clean (otherwise we
+ // can get into trouble not installing plugins if
someone deletes the platform folder but
+ // <platform>.json still exists).
+ removePlatformPluginsJson(projectRoot, target);
--- End diff --
Regarding your first point: If you look at the context of where the call
was added, it is within an `if (cmd == 'add')` check.
Regarding your second point - no, we still want the file deleted even if
the `add` operation fails. Essentially we're just putting things into the state
they would have been in if the platform had been properly removed, so we want
to get into that state as early as possible.
> Plugins don't get re-added if platforms folder deleted
> ------------------------------------------------------
>
> Key: CB-9051
> URL: https://issues.apache.org/jira/browse/CB-9051
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib, Plugman
> Affects Versions: 5.0.0
> Reporter: Tim Barham
> Assignee: Tim Barham
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> If you add a platform, the delete the platforms folder (or just the folder
> for that specific platform), then add the platform again, no plugins are
> installed for that platform.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
