[ 
https://issues.apache.org/jira/browse/CB-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554695#comment-14554695
 ] 

ASF GitHub Bot commented on CB-9051:
------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/223#discussion_r30825223
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -122,6 +122,12 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
                             if (platformAlreadyAdded) {
                                 throw new CordovaError('Platform ' + platform 
+ ' already added.');
                             }
    +
    +                        // Remove the <platform>.json file from the 
plugins directory, so we start clean (otherwise we
    +                        // can get into trouble not installing plugins if 
someone deletes the platform folder but
    +                        // <platform>.json still exists).
    +                        removePlatformPluginsJson(projectRoot, target);
    --- End diff --
    
    Fair points! LGTM!


> Plugins don't get re-added if platforms folder deleted
> ------------------------------------------------------
>
>                 Key: CB-9051
>                 URL: https://issues.apache.org/jira/browse/CB-9051
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugman
>    Affects Versions: 5.0.0
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you add a platform, the delete the platforms folder (or just the folder 
> for that specific platform), then add the platform again, no plugins are 
> installed for that platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to