[ 
https://issues.apache.org/jira/browse/CB-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554660#comment-14554660
 ] 

ASF GitHub Bot commented on CB-9051:
------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/223#discussion_r30822641
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -663,6 +668,12 @@ function copy_cordovajs_src(projectRoot, platform, 
platLib) {
         } 
     }
     
    +// Remove <platform>.json file from plugins directory.
    +function removePlatformPluginsJson(projectRoot, target) {
    +    var plugins_json = path.join(projectRoot, 'plugins', target + '.json');
    +    if (fs.existsSync(plugins_json)) shell.rm(plugins_json);
    --- End diff --
    
    Nit: you can use shell.rm('-f', plugins_json) and then you do not need an 
exists check.


> Plugins don't get re-added if platforms folder deleted
> ------------------------------------------------------
>
>                 Key: CB-9051
>                 URL: https://issues.apache.org/jira/browse/CB-9051
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugman
>    Affects Versions: 5.0.0
>            Reporter: Tim Barham
>            Assignee: Tim Barham
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If you add a platform, the delete the platforms folder (or just the folder 
> for that specific platform), then add the platform again, no plugins are 
> installed for that platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to