[
https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769035#comment-14769035
]
ASF GitHub Bot commented on CB-9598:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/309
CB-9598 Introduces `cordova-common` module
This is an implementation for
[CB-9598](https://issues.apache.org/jira/browse/CB-9598) and the next step of
platformApi refactoring. The idea is to move all code that potentially will be
shared between different platforms and LIB into a separate module that will be
used by both LIB an platforms.
This PR only copies existing code from cordova-lib into cordova-common, but
doesn't switches cordova-lib to use it. Once this PR is merged we can remove
this functionality from cordova-lib and switch to using cordova-common.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 1959844d1ee3053bfb87255542ff5ee7739fb541
Author: Vladimir Kotikov <[email protected]>
Date: 2015-09-16T13:39:52Z
CB-9598 Initial implementation for cordova-common module
commit 63784f6547d682ff3a30713a4d20153fb606fe11
Author: Vladimir Kotikov <[email protected]>
Date: 2015-09-16T13:39:41Z
CB-9598 Adds tests and fixtures based on existing cordova-lib ones
----
> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
> Key: CB-9598
> URL: https://issues.apache.org/jira/browse/CB-9598
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaCommon, CordovaLib
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi
> needs for several classes, which currently being stored and exposed by
> cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this
> problem - is to factor out the common classes and routines to shared module
> (proposed name - cordova-common), which then will be released separately.
> This approach is discussed in cordova-lib/#235
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
