[
https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14852726#comment-14852726
]
ASF GitHub Bot commented on CB-9598:
------------------------------------
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/309#issuecomment-141443458
@nikhilkh, regarding your concern about iOS specific dependencies (`xcode`,
`plist` and `bplist-parser`) for this - the reason is that `ConfigChanges`
class still uses them to do some special config processing.
We can get rid of this ios specifics only when we'll end supporing old
platforms (`ios` in particular) via `PlatformApiPoly`.
BTW there is exactly the same situation with Windows platform - there is
some logic that spreads appxmanifest changes to all appxmanifest files in
project (see
[generate_plugin_config_munge](https://github.com/MSOpenTech/cordova-lib/commit/9245da38f30e61ab98595e8916aea175f7d88f56#diff-cd932e6542e2f88b0f2c0dd0907b7481R274)),
which we'll need to keep there while supporting non-platformApi-compatible
platform.
> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
> Key: CB-9598
> URL: https://issues.apache.org/jira/browse/CB-9598
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaCommon, CordovaLib
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi
> needs for several classes, which currently being stored and exposed by
> cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this
> problem - is to factor out the common classes and routines to shared module
> (proposed name - cordova-common), which then will be released separately.
> This approach is discussed in cordova-lib/#235
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
