[ 
https://issues.apache.org/jira/browse/CB-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108664#comment-15108664
 ] 

jcesarmobile commented on CB-10388:
-----------------------------------

read the contributor workflow http://wiki.apache.org/cordova/ContributorWorkflow
create a fork of https://github.com/apache/cordova-plugin-camera
fix the issue in your fork
send a pull request
wait until it's approved

> The correctOrientation method is not being called when the sourceType as 
> PHOTOLIBRARY, the mediaType is ALLMEDIA and the selected file is an image 
> (Only for Android devices)
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-10388
>                 URL: https://issues.apache.org/jira/browse/CB-10388
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Camera
>    Affects Versions: 1.2.0, 2.0.0, 2.1.0
>         Environment: Developing on MAC, android devices used: Xperia Z3, Dell 
> venue7
>            Reporter: Hernan Orozco
>              Labels: android, camera, easyfix, easytest
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The correctOrientation function is used to fix the orientation of a photo, if 
> this method is not called and you take a picture in portrait mode, the 
> picture is going to be shown with a wrong orientation. To activate this 
> feature we should send the correctOrientation param as true. The issue is 
> that the current android code is only calling the correctOrientation method 
> in these cases:
> - When you pass the correctOrientation param as true and the sourceType as 
> CAMERA.
> - When you pass the correctOrientation param as true, the sourceType as 
> PHOTOLIBRARY or SAVEDPHOTOALBUM and the media type as PICTURE.
> I think we should include this case:
> - You pass the correctOrientation param as true, the sourceType as 
> PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as ALLMEDIA and the selected 
> file is a picture.
> Also I want to add that I was able to reproduce the issue CB-9012, that issue 
> and this one are a little related so I think we can create a fix for both 
> issues. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to