[
https://issues.apache.org/jira/browse/CB-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111313#comment-15111313
]
ASF GitHub Bot commented on CB-10388:
-------------------------------------
GitHub user horozco opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/158
[CB-10388] - Added correctOrientation support for android 4.4
Jira issue: https://issues.apache.org/jira/browse/CB-10388
- Currently If You pass the correctOrientation param as true, the
sourceType as PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as ALLMEDIA and
the selected file is an image the correctOrientation function is not being
called. Also even if the function is called the code is not detecting the URI
and doesn’t rotate the picture. These changes fixed both issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/horozco/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit e2823f48d632e12f89960fe83ebc90ba7d0a5a6a
Author: Hernan Orozco <[email protected]>
Date: 2016-01-21T21:02:11Z
[CB-10388] - Added correctOrientation support for android 4.4
- Currently If You pass the correctOrientation param as true, the
sourceType as PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as
ALLMEDIA and the selected file is an image the correctOrientation
function is not being called. Also even if the function is called the
code is not detecting the uri and doesn’t rotate the picture. These
changes fixed both issues.
----
> The correctOrientation method is not being called when the sourceType as
> PHOTOLIBRARY, the mediaType is ALLMEDIA and the selected file is an image
> (Only for Android devices)
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-10388
> URL: https://issues.apache.org/jira/browse/CB-10388
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Camera
> Affects Versions: 1.2.0, 2.0.0, 2.1.0
> Environment: Developing on MAC, android devices used: Xperia Z3, Dell
> venue7
> Reporter: Hernan Orozco
> Labels: android, camera, easyfix, easytest
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The correctOrientation function is used to fix the orientation of a photo, if
> this method is not called and you take a picture in portrait mode, the
> picture is going to be shown with a wrong orientation. To activate this
> feature we should send the correctOrientation param as true. The issue is
> that the current android code is only calling the correctOrientation method
> in these cases:
> - When you pass the correctOrientation param as true and the sourceType as
> CAMERA.
> - When you pass the correctOrientation param as true, the sourceType as
> PHOTOLIBRARY or SAVEDPHOTOALBUM and the media type as PICTURE.
> I think we should include this case:
> - You pass the correctOrientation param as true, the sourceType as
> PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as ALLMEDIA and the selected
> file is a picture.
> Also I want to add that I was able to reproduce the issue CB-9012, that issue
> and this one are a little related so I think we can create a fix for both
> issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
