[
https://issues.apache.org/jira/browse/CB-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122784#comment-15122784
]
ASF GitHub Bot commented on CB-10388:
-------------------------------------
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-176528759
Thanks for submitting a PR! The ALLMEDIA thing definitely sounds like a bug
and your change there looks good.
However, I'm not 100% sure about the changes you made to
`getImageOrientation()`. The issue is that when we get an image URI, it may or
may not map to an actual file location depending on the application that
provided the URI. For example, Google Photos can provide URIs that point to
images in the cloud and not on the physical device. In this case, using the
content resolver is the correct method for getting the orientation because the
content resolver knows how to handle those situations. Thoughts?
> The correctOrientation method is not being called when the sourceType as
> PHOTOLIBRARY, the mediaType is ALLMEDIA and the selected file is an image
> (Only for Android devices)
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CB-10388
> URL: https://issues.apache.org/jira/browse/CB-10388
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
> Affects Versions: 1.2.0, 2.0.0, 2.1.0
> Environment: Developing on MAC, android devices used: Xperia Z3, Dell
> venue7
> Reporter: Hernan Orozco
> Labels: android, camera, easyfix, easytest, triaged
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The correctOrientation function is used to fix the orientation of a photo, if
> this method is not called and you take a picture in portrait mode, the
> picture is going to be shown with a wrong orientation. To activate this
> feature we should send the correctOrientation param as true. The issue is
> that the current android code is only calling the correctOrientation method
> in these cases:
> - When you pass the correctOrientation param as true and the sourceType as
> CAMERA.
> - When you pass the correctOrientation param as true, the sourceType as
> PHOTOLIBRARY or SAVEDPHOTOALBUM and the media type as PICTURE.
> I think we should include this case:
> - You pass the correctOrientation param as true, the sourceType as
> PHOTOLIBRARY or SAVEDPHOTOALBUM, the media type as ALLMEDIA and the selected
> file is a picture.
> Also I want to add that I was able to reproduce the issue CB-9012, that issue
> and this one are a little related so I think we can create a fix for both
> issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
