[
https://issues.apache.org/jira/browse/CB-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236905#comment-15236905
]
ASF GitHub Bot commented on CB-10986:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59346334
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,8 +132,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
));
}
// If not found in local search path, fetch from the registry.
- var splitVersion = plugin_src.split('@');
- var newID = pluginMapperotn[splitVersion[0]];
+ var splitVersion =
cordovaUtil.parseRegistryPluginSpec(plugin_src);
+ var oldId = splitVersion[0] || plugin_src;
+ var newID = pluginMapperotn[oldId];
--- End diff --
Since `oldId` could be either package id or scope + package id i'm not sure
how this will work with plugin mapper. Should we use `extractPluginId` instead
of `parseRegistryPluginSpec` in L135?
> Unable to install npm scoped plugin with [email protected]
> ----------------------------------------------------------
>
> Key: CB-10986
> URL: https://issues.apache.org/jira/browse/CB-10986
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.1.0
> Reporter: Darryl Pogue
> Assignee: Richard B Knoll
> Labels: regression, reproduced, triaged
>
> {code}
> $ cordova create MyProject
> $ cd ./MyProject
> $ cordova platform add android
> $ cordova plugin add @dpogue/cordova-plugin-crosswalk-webview
> Error: Cannot find plugin.xml for plugin 'plugins'. Please try adding it
> again.
> {code}
> This works as expected with [email protected].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
