[
https://issues.apache.org/jira/browse/CB-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236920#comment-15236920
]
ASF GitHub Bot commented on CB-10986:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347577
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -205,8 +206,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
// Helper function for checking expected plugin IDs against reality.
function checkID(expectedIdAndVersion, pinfo) {
if (!expectedIdAndVersion) return;
- var expectedId = expectedIdAndVersion.split('@')[0];
- var expectedVersion = expectedIdAndVersion.split('@')[1];
+ var parts = cordovaUtil.parseRegistryPluginSpec(expectedIdAndVersion);
+ var expectedId = parts[0] || expectedIdAndVersion;
+ var expectedVersion = parts[1];
if (expectedId != pinfo.id) {
--- End diff --
Since you use `parseRegistryPluginSpec`, it is possible that `expectedId`
would be specified as `@scope/id`, but from what i understand, pluginInfo.id
could not contain scope so this comparison will always be truthy in this case
> Unable to install npm scoped plugin with [email protected]
> ----------------------------------------------------------
>
> Key: CB-10986
> URL: https://issues.apache.org/jira/browse/CB-10986
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.1.0
> Reporter: Darryl Pogue
> Assignee: Richard B Knoll
> Labels: regression, reproduced, triaged
>
> {code}
> $ cordova create MyProject
> $ cd ./MyProject
> $ cordova platform add android
> $ cordova plugin add @dpogue/cordova-plugin-crosswalk-webview
> Error: Cannot find plugin.xml for plugin 'plugins'. Please try adding it
> again.
> {code}
> This works as expected with [email protected].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
