[
https://issues.apache.org/jira/browse/CB-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236926#comment-15236926
]
ASF GitHub Bot commented on CB-10986:
-------------------------------------
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59349270
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -145,10 +145,9 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
var deps = pluginInfo.getDependencies();
var deps_path;
deps.forEach(function (d) {
- var splitVersion = d.id.split('@');
- deps_path = path.join(plugin_dir, '..', splitVersion[0]);
+ deps_path = path.join(plugin_dir, '..',
cordovaUtil.extractPluginId(d.id));
if (!fs.existsSync(deps_path)) {
- var newId = pluginMapper[splitVersion[0]];
+ var newId =
pluginMapper[cordovaUtil.parseRegistryPluginSpec(d.id)[0] || d.id];
--- End diff --
You use `extractPluginId` in L148 but `parseRegistryPluginSpec` here but
they will return different results in case if there is a scoped dependency in
plugin.xml. Is that intentional?
> Unable to install npm scoped plugin with [email protected]
> ----------------------------------------------------------
>
> Key: CB-10986
> URL: https://issues.apache.org/jira/browse/CB-10986
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: 6.1.0
> Reporter: Darryl Pogue
> Assignee: Richard B Knoll
> Labels: regression, reproduced, triaged
>
> {code}
> $ cordova create MyProject
> $ cd ./MyProject
> $ cordova platform add android
> $ cordova plugin add @dpogue/cordova-plugin-crosswalk-webview
> Error: Cannot find plugin.xml for plugin 'plugins'. Please try adding it
> again.
> {code}
> This works as expected with [email protected].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
