[
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262488#comment-15262488
]
ASF GitHub Bot commented on CB-11074:
-------------------------------------
GitHub user ephemer opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8
CB-11074: Ensure settings from config.xml are taken into consideration
#7 also addresses this issue but in my tests didn't work.
This pull request presents a workaround that requires two WKWebView
instances to be inited (only one is kept and used for the app though). This
isn't supposed to be merged as is, it's more a proof of concept and designed to
provide exposure to the workaround if others users need this fix urgently.
@shazron the logic presented in this PR would have been made more
complicated via the updateWithInfo: method, which as far as I could see is
unused, so I removed it for now. Other than that, what do you think about this
as general direction.
As I commented in #7, the best approach for this would be to change
`CDVViewController.m` to pass in the settings directly on init, or to rearrange
the check logic there. That is a longer-term solution. In the meantime, maybe
we can get by with the approach presented here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ephemer/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit b87ad79a12af05c9a14559dd3f1d8e658493c27c
Author: Geordie J <[email protected]>
Date: 2016-04-28T16:39:17Z
CB-11074: Ensure settings from config.xml are taken into consideration
----
> WKWebView configuration is not considered
> -----------------------------------------
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Environment: ios
> Reporter: Alexis Kofman
> Priority: Critical
> Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
