[
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263184#comment-15263184
]
ASF GitHub Bot commented on CB-11074:
-------------------------------------
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215584737
@ephemer not just settings (which as you said will probably not a frequent
scenario), but setting the other delegates. updateWithInfo will be used for
certain apps that need to set their own delegates on the webViewEngines -- a
minor case, but I encountered this just last week.
I don't think self.webViewEngine will fail in the case of your 'preferred
approach' you mentioned since that is just the CDVPlugin object wrapper that
will always be instantiated unless WKWebView is not available:
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/33a75172a1450e8922788cd23382cc6ec33845c7/src/ios/CDVWKWebViewEngine.m#L47-L49
I'll comment on your #8 pull request.
> WKWebView configuration is not considered
> -----------------------------------------
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Environment: ios
> Reporter: Alexis Kofman
> Priority: Critical
> Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
