[
https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263194#comment-15263194
]
ASF GitHub Bot commented on CB-11074:
-------------------------------------
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215585938
I also commented on #7.
To solve this problem, instead of having to instantiate WKWebView twice
here, I think we can safely move all initializing code from the initWithFrame,
to pluginInitialize:
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/33a75172a1450e8922788cd23382cc6ec33845c7/src/ios/CDVWKWebViewEngine.m#L50-L64
-- all we need to do is save the CGRect for the frame for later. At this
point, with this approach, the WKWebView will have been instantiated for this
return call:
https://github.com/apache/cordova-ios/blob/e51eda0f3b1e68d210182c3bbd3d9022c1ffe8ec/CordovaLib/Classes/Public/CDVViewController.m#L426
As I mentioned in #7, we still need updateWithInfo.
The rest of your approach is sound.
> WKWebView configuration is not considered
> -----------------------------------------
>
> Key: CB-11074
> URL: https://issues.apache.org/jira/browse/CB-11074
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Environment: ios
> Reporter: Alexis Kofman
> Priority: Critical
> Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a
> readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after
> initialising it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
