[ 
https://issues.apache.org/jira/browse/CB-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287222#comment-15287222
 ] 

ASF GitHub Bot commented on CB-11279:
-------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/122#discussion_r63578645
  
    --- Diff: src/nightly.js ---
    @@ -60,36 +62,26 @@ module.exports = function*(argv) {
         }
     
         // Clone and update Repos
    -    yield repoclone.cloneRepos(repos, /*silent=*/true);
    -    yield repoupdate.updateRepos(repos);
    -
    -    //remove local changes and sync up with remote master
    -    yield repoutil.forEachRepo(repos, function*() {
    -        yield gitutil.gitClean();
    -        yield gitutil.resetFromOrigin();
    -    });
    +    yield prepareRepos(argv.r);
    --- End diff --
    
    :nit it's a bit hard to reason about these yields (especially the nested 
ones).


> Add support for multiple repos ('--repo' option) to 'coho nightly' command
> --------------------------------------------------------------------------
>
>                 Key: CB-11279
>                 URL: https://issues.apache.org/jira/browse/CB-11279
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Coho
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to