[ https://issues.apache.org/jira/browse/CB-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289634#comment-15289634 ]
ASF GitHub Bot commented on CB-11279: ------------------------------------- Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/122#discussion_r63765329 --- Diff: src/nightly.js --- @@ -60,36 +62,26 @@ module.exports = function*(argv) { } // Clone and update Repos - yield repoclone.cloneRepos(repos, /*silent=*/true); - yield repoupdate.updateRepos(repos); + yield prepareRepos(argv.r); - //remove local changes and sync up with remote master - yield repoutil.forEachRepo(repos, function*() { - yield gitutil.gitClean(); - yield gitutil.resetFromOrigin(); - }); + var reposToBuild = flagutil.computeReposFromFlag(argv.r, { includeModules: true }); + // Get updated nightly versions for all repos + /** @type {Object} A map of repo.id and a short SHA for every repo to build */ + var VERSIONS = yield retrieveVersions(reposToBuild); - // Get SHAS from repos - var SHAJSON = yield retrieveSha(repos); + // Update version in package.json and other respective files for every repo + // and update dependencies to use nightly versions of packages to be released + yield repoutil.forEachRepo(reposToBuild, function*(repo) { + apputil.print('Updating ' + repo.id + ' version to ' + VERSIONS[repo.id]); + yield versionutil.updateRepoVersion(repo, VERSIONS[repo.id], { commitChanges: false }); - var currentDate = new Date(); - var nightlyVersion = '-nightly.' + currentDate.getFullYear() + '.' + - (currentDate.getMonth() + 1) + '.' + currentDate.getDate(); - var cordovaLibVersion; - //update package.json version for cli + lib, update lib reference for cli - yield repoutil.forEachRepo([cordovaLib, cli], function*(repo) { - var dir = process.cwd(); - var packageJSON = require(dir+'/package.json'); - packageJSON.version = versionutil.removeDev(packageJSON.version) + nightlyVersion + - '+' + SHAJSON[repo.id]; - - if(repo.id === 'lib'){ - cordovaLibVersion = packageJSON.version; - } else { - packageJSON.dependencies['cordova-lib'] = cordovaLibVersion; - } + var packageJSONPath = path.join(process.cwd(), 'package.json'); --- End diff -- Looks like updateRepoVersion already updates package.json - you can probably remove the code here. > Add support for multiple repos ('--repo' option) to 'coho nightly' command > -------------------------------------------------------------------------- > > Key: CB-11279 > URL: https://issues.apache.org/jira/browse/CB-11279 > Project: Apache Cordova > Issue Type: Sub-task > Components: Coho > Reporter: Vladimir Kotikov > Assignee: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org