[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323129#comment-15323129
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
I've tested it out and I think there needs to be a slight tweak to the
`--force` behavior. When a plugin is force added, any conflicting edit-config
changes it has should not be applied. Otherwise, you can get into a weird
situation where adding conflicting plugins and removing them in a bad order
results in the config file being different than when you started.
For example, If I have two plugins that conflict and I execute the
following commands:
```
cordova plugin add plugin-1
cordova plugin add plugin-2 --force
cordova plugin rm plugin-1
cordova plugin rm plugin-2
```
I will be left with a config file that has the changes that `plugin-1`
made despite `plugin-1` no longer being in my project. I think it's a good idea
to always make it so that removing all plugins will get you back to where you
started.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
