[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323256#comment-15323256
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user riknoll commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@ktop Run `git log` and check out the author field. Your email shows up,
but the name is unknown for some reason.
As for the force add thing, that sounds fine to me. There are two possible
behaviors:
1. When you force add a plugin, remove any existing changes (i.e. the
changes of plugin 1) and apply the new changes (from plugin 2)
2. When you force add a plugin, ignore any conflicting changes (i.e. the
changes of plugin 2) and leave the existing ones in place (from plugin 1)
I believe you are describing the first behavior. The difference between
that and the current implementation is that the current implementation
shouldn't store both sets of changes in platform.json. If the changes of plugin
1 get overwritten by plugin 2, then they should be undone before the changes of
plugin 2 are made. Otherwise, the platform.json gets into a weird state.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
