[
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293694#comment-15293694
]
ASF GitHub Bot commented on CB-11023:
-------------------------------------
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220658702
My suggestion was to separate editing and inserting altogether. Continue to
have a `config-file` tag that works exactly like before for adding things to
XML, and have a new differently named tag for editing existing tags (like
`edit-config`). The new tag wouldn't specify a parent, it would use the xpath
selector to specify the element to be edited directly. We do lose the ability
to edit a bunch of tags all at once like you say, but I don't think it would be
too cumbersome to add a separate element for each edit we want to make.
> plugin.xml should be able to add attribute to an existing element in
> AndroidManifest.xml
> ----------------------------------------------------------------------------------------
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI, Plugman
> Reporter: Carlos Santana
>
> We have a need for a plugin we develop to add the attribute android:name to
> the <application> element to be able to point to a Class that tracks app
> sessions for analytics.
> plugin.xml only support via <config-file> only to add elements to
> AndroidManfist.xml this request is to add an enhancement to also handle
> adding an attribute to an existing element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
