[
https://issues.apache.org/jira/browse/CB-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557352#comment-15557352
]
ASF GitHub Bot commented on CB-11985:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/498
## [Current
coverage](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr) is 80.57%
(diff: 100%)
> Merging [#498](https://codecov.io/gh/apache/cordova-lib/pull/498?src=pr)
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr)
will increase coverage by **0.17%**
```diff
@@ master #498 diff @@
==========================================
Files 67 67
Lines 5189 5205 +16
Methods 836 840 +4
Messages 0 0
Branches 1005 1007 +2
==========================================
+ Hits 4172 4194 +22
+ Misses 1017 1011 -6
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update
[4ca3b4c...83540e7](https://codecov.io/gh/apache/cordova-lib/compare/4ca3b4ca12a01ded923734e4d92d7f9325d540dc...83540e74027fa44769ff8b3e80bf35b3cba152dc?src=pr)
> Cordova hits internet unnecessarily when getting cached platform or plugin
> --------------------------------------------------------------------------
>
> Key: CB-11985
> URL: https://issues.apache.org/jira/browse/CB-11985
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Affects Versions: 6.3.1
> Reporter: Tim Barham
> Assignee: Tim Barham
>
> In you are disconnected from the internet and try to add a platform or plugin
> that has previously been cached, Cordova eventually successfully installs the
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling
> {{npm cache add}}. This would mean an instant return when not connected to
> the internet.
> Note that this will only help if we are adding a specific version - when a
> version range is specified, we need to hit the internet anyway to find the
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are
> primarily due to {{npm}} failures. Therefore we are working to avoid any
> requirement for {{npm}}} to hit the internet in simple build scenarios. This
> includes pre-installing cached versions of certain platforms and plugins. But
> we only get the full benefit if Cordova uses these cached versions if it
> finds them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
