[
https://issues.apache.org/jira/browse/CB-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561740#comment-15561740
]
ASF GitHub Bot commented on CB-11985:
-------------------------------------
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-lib/pull/498
@brodybits - that hasn't changed. At the point where we're looking for a
cached version, we have already determined the latest version that matches the
requested range (for both platforms and plugins). If a version range is
specified, we have to hit the internet to determine the latest version that
matches that range (and this change doesn't provide any real benefit). If a
specific version is specified (which will be the case in VS), then that is the
version we'll get (cached if it is there, otherwise have to download).
The only change here from a user's perspective should be that plugins are
cached in the same place as platforms (in the `.cordova` directory).
> Cordova hits internet unnecessarily when getting cached platform or plugin
> --------------------------------------------------------------------------
>
> Key: CB-11985
> URL: https://issues.apache.org/jira/browse/CB-11985
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Affects Versions: 6.3.1
> Reporter: Tim Barham
> Assignee: Tim Barham
>
> In you are disconnected from the internet and try to add a platform or plugin
> that has previously been cached, Cordova eventually successfully installs the
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling
> {{npm cache add}}. This would mean an instant return when not connected to
> the internet.
> Note that this will only help if we are adding a specific version - when a
> version range is specified, we need to hit the internet anyway to find the
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are
> primarily due to {{npm}} failures. Therefore we are working to avoid any
> requirement for {{npm}}} to hit the internet in simple build scenarios. This
> includes pre-installing cached versions of certain platforms and plugins. But
> we only get the full benefit if Cordova uses these cached versions if it
> finds them, without calling {{npm cache add}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
