ASF GitHub Bot commented on CB-11985:

Github user asfgit closed the pull request at:


> Cordova hits internet unnecessarily when getting cached platform or plugin
> --------------------------------------------------------------------------
>                 Key: CB-11985
>                 URL: https://issues.apache.org/jira/browse/CB-11985
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>            Reporter: Tim Barham
>            Assignee: Tim Barham
> In you are disconnected from the internet and try to add a platform or plugin 
> that has previously been cached, Cordova eventually successfully installs the 
> platform/plugin, but only after a very long wait.
> We could check for the existence of the cached platform/plugin before calling 
> {{npm cache add}}. This would mean an instant return when not connected to 
> the internet.
> Note that this will only help if we are adding a specific version - when a 
> version range is specified, we need to hit the internet anyway to find the 
> matching version.
> Background: First time build failures in Cordova tools in Visual Studio are 
> primarily due to {{npm}} failures. Therefore we are working to avoid any 
> requirement for {{npm}}} to hit the internet in simple build scenarios. This 
> includes pre-installing cached versions of certain platforms and plugins. But 
> we only get the full benefit if Cordova uses these cached versions if it 
> finds them, without calling {{npm cache add}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to