[
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896800#comment-15896800
]
ASF GitHub Bot commented on CB-12543:
-------------------------------------
GitHub user cnspaha opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
CB-12543 (iOS) Set orientation on when locking the device
### Platforms affected
iOS
### What does this PR do?
Instead of just locking the orientation, it also rotates to it. Mandatory
for iOS.
### What testing has been done on this change?
Manual testing on iOS 10, iPhone 6+.
Run: "npm test"
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cadenasgmbh/cordova-plugin-screen-orientation
setOrientationOnLock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 7185add951fff8d405338af5ef812cb34c476315
Author: Pascal Häusler <[email protected]>
Date: 2017-03-03T14:03:09Z
Rotate to specified orientation when locked
commit 141dea7e6b28f3900e530dd7e2def21f762e807d
Author: Pascal Häusler <[email protected]>
Date: 2017-03-06T06:19:56Z
Refactor
commit fbe1c98d8c9389dabaef23b5c0b31b015ff87c3b
Author: Pascal Häusler <[email protected]>
Date: 2017-03-06T06:26:54Z
Update screenorientation.js to prevent jshint to fail test
commit 2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f
Author: Pascal Häusler <[email protected]>
Date: 2017-03-06T06:27:34Z
Update CDVOrientationproxy.js to prevent jshint to fail test
----
> Lock Orientation on iOS doesn't work correctly
> ----------------------------------------------
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Screen Orientation
> Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
> Reporter: Pascal
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait
> mode and then lock it to landscape, it appears that the webview is rotated
> but not the "screen"
> => only half of the webview is still visible since it isn't resized to the
> new orientation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
