[
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903909#comment-15903909
]
ASF GitHub Bot commented on CB-12543:
-------------------------------------
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11#discussion_r105280210
--- Diff: www/screenorientation.js ---
@@ -54,7 +54,7 @@
screenObject.lock = function(orientation) {
var promiseLock;
var p = new Promise(function(resolve, reject) {
- if (screenObject.nativeLock != null) {
+ if (screenObject.nativeLock !== null) {
--- End diff --
if you are gonna be strict, then you would have to test for undefined also
> Lock Orientation on iOS doesn't work correctly
> ----------------------------------------------
>
> Key: CB-12543
> URL: https://issues.apache.org/jira/browse/CB-12543
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Screen Orientation
> Affects Versions: Master
> Environment: iOS 10
> iPhone 6+
> Reporter: Pascal
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait
> mode and then lock it to landscape, it appears that the webview is rotated
> but not the "screen"
> => only half of the webview is still visible since it isn't resized to the
> new orientation
> - Already made a PR on
> https://github.com/apache/cordova-plugin-screen-orientation/pulls
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
