[ 
https://issues.apache.org/jira/browse/CB-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940018#comment-15940018
 ] 

ASF GitHub Bot commented on CB-12543:
-------------------------------------

Github user Sh1d0w commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/11
  
    The proposed fix works ok (reverted `screenObject.nativeLock !== null` back 
to `screenObject.nativeLock != null`), expect that it does not force rotate the 
screen if you are already holding the phone in that orientation. What I mean:
    
    Lock the screen to landscape while holding the phone vertically. It will 
work ok.
    Rotate the phone horizontal, then rotate it again vertically.
    
    Now lock the phone to portrait, the web view will remain in landscape mode 
until you shake it.


> Lock Orientation on iOS doesn't work correctly
> ----------------------------------------------
>
>                 Key: CB-12543
>                 URL: https://issues.apache.org/jira/browse/CB-12543
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Screen Orientation
>    Affects Versions: Master
>         Environment: iOS 10
> iPhone 6+
>            Reporter: Pascal
>            Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When I haven't locked the orientation so far and held my iPhone in portrait 
> mode and then lock it to landscape, it appears that the webview is rotated 
> but not the "screen" 
> => only half of the webview is still visible since it isn't resized to the 
> new orientation
> - Already made a PR on 
> https://github.com/apache/cordova-plugin-screen-orientation/pulls



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to