[
https://issues.apache.org/jira/browse/CB-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067144#comment-16067144
]
ASF GitHub Bot commented on CB-12966:
-------------------------------------
GitHub user joshdholtz opened a pull request:
https://github.com/apache/cordova-ios/pull/324
CB-12966: (ios) Fix bug by escaping project name in podfile template
### Platforms affected
- iOS
### What does this PR do?
- Fixes a bug when the project name has a single quote in it that caused
the `Podfile` to have invalid syntax
### What testing has been done on this change?
- Just manual testing on my own project. I am not familiar with how to
write a proper tests for this change 😔 I know I need to add something in
`Podfile.spec.js` but not exactly sure what/how exactly I need to do this. Any
suggestions on how to write these tests would be truly appreciated ❤️
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshdholtz/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit ff8061e4de993ec5104701a7211a57b774a9fb74
Author: Josh Holtz <[email protected]>
Date: 2017-06-28T17:22:27Z
CB-12966: (ios) Fix bug by escaping project name in podfile template
----
> cordova-ios Podfile template does not escape project names containing a
> single quote
> ------------------------------------------------------------------------------------
>
> Key: CB-12966
> URL: https://issues.apache.org/jira/browse/CB-12966
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: [email protected], [email protected]
> Environment: iOS platform
> Reporter: Josh Holtz
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: ios, patch
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The Podfile template does not escape single quotes for project names when
> generating the Podfile. This will cause a syntax error in the Podfile since
> the target and project are single quoted strings. The solution is to escape
> the single quotes in the project name before writing them to the Podfile.
> I already have a fix for this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
