[
https://issues.apache.org/jira/browse/CB-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082161#comment-16082161
]
ASF GitHub Bot commented on CB-12966:
-------------------------------------
Github user joshdholtz commented on the issue:
https://github.com/apache/cordova-ios/pull/324
@shazron Rebased from master so that the tests and linter actually run and
pass now. Also separated out the escaping of single quotes into its own
function for better testing and added a tests for that new function. Lemme know
if there is anything I need to change to make these changes fit better with the
style of this project 🙃
> cordova-ios Podfile template does not escape project names containing a
> single quote
> ------------------------------------------------------------------------------------
>
> Key: CB-12966
> URL: https://issues.apache.org/jira/browse/CB-12966
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: [email protected], [email protected]
> Environment: iOS platform
> Reporter: Josh Holtz
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: ios, patch
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The Podfile template does not escape single quotes for project names when
> generating the Podfile. This will cause a syntax error in the Podfile since
> the target and project are single quoted strings. The solution is to escape
> the single quotes in the project name before writing them to the Podfile.
> I already have a fix for this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
