[
https://issues.apache.org/jira/browse/CB-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082125#comment-16082125
]
ASF GitHub Bot commented on CB-12966:
-------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/324
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=h1)
Report
> Merging
[#324](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 63.77% 63.79% +0.02%
==========================================
Files 14 14
Lines 1623 1624 +1
Branches 277 277
==========================================
+ Hits 1035 1036 +1
Misses 588 588
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=)
| `75.86% <100%> (+0.2%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=footer).
Last update
[26beb94...c66b4ba](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
> cordova-ios Podfile template does not escape project names containing a
> single quote
> ------------------------------------------------------------------------------------
>
> Key: CB-12966
> URL: https://issues.apache.org/jira/browse/CB-12966
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: [email protected], [email protected]
> Environment: iOS platform
> Reporter: Josh Holtz
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: ios, patch
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The Podfile template does not escape single quotes for project names when
> generating the Podfile. This will cause a syntax error in the Podfile since
> the target and project are single quoted strings. The solution is to escape
> the single quotes in the project name before writing them to the Podfile.
> I already have a fix for this issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
