[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123639#comment-16123639 ]
ASF GitHub Bot commented on CB-12361: ------------------------------------- Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/582#discussion_r132736117 --- Diff: spec/cordova/plugin/search.spec.js --- @@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () { console.error(e); }).done(done); }); - it('should open a link to cordova.apache.org/plugins if no plugins are provided as parameter'); - it('should open a link to cordova.apache.org/plugins, providing the plugins passed in as a query-string parameter'); - it('should fire the after_plugin_search hook'); + + it('should open a link to cordova.apache.org/plugins if no plugins are provided as parameter', function (done) { + var opts = {important: 'options', plugins: []}; + search(hook_mock, opts).then(function () { + expect(opener_mock).toHaveBeenCalled(); + }).fail(function (e) { + console.log(e); --- End diff -- Don't think you need console.log(e) since you console.error two lines below > Speed up cordova-lib tests > -------------------------- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib > Reporter: Steve Gill > Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org