[
https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123852#comment-16123852
]
ASF GitHub Bot commented on CB-12361:
-------------------------------------
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/581#discussion_r132758763
--- Diff: src/cordova/plugin/remove.js ---
@@ -68,6 +68,7 @@ function remove (projectRoot, targets, hooksRunner, opts)
{
// If platform does not returned anything
we'll need
// to trigger a prepare after all plugins
installed
// TODO: if didPrepare is falsy, what does
that imply? WHY are we doing this?
+ events.emit('verbose', 'Calling prepare.');
--- End diff --
I think you might want to remove this event. Since Prepare will only be
called if `didPrepare` is falsy. So you could get the output `calling prepare`
when you actually don't call prepare
> Speed up cordova-lib tests
> --------------------------
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
