ASF GitHub Bot commented on CB-12361:

Github user stevengill commented on a diff in the pull request:

    --- Diff: spec/cordova/platform/list.spec.js ---
    @@ -0,0 +1,75 @@
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +    http://www.apache.org/licenses/LICENSE-2.0
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +var events = require('cordova-common').events;
    +var Q = require('q');
    +var rewire = require('rewire');
    +var platform_list = rewire('../../../src/cordova/platform/list');
    --- End diff --
    i don't think you use rewire anywhere in this file

> Speed up cordova-lib tests
> --------------------------
>                 Key: CB-12361
>                 URL: https://issues.apache.org/jira/browse/CB-12361
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>              Labels: cordova-next
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to