[ 
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217781#comment-16217781
 ] 

ASF GitHub Bot commented on CB-13290:
-------------------------------------

codecov-io commented on issue #344: CB-13290: (ios) Update splash screen 
mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#issuecomment-339147131
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=h1) 
Report
   > Merging 
[#344](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/ac2e1de177a81ffb57206328552b96bac5501434?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/344/graphs/tree.svg?src=pr&token=WomDD5jInz&width=650&height=150)](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #344   +/-   ##
   =======================================
     Coverage   63.43%   63.43%           
   =======================================
     Files          14       14           
     Lines        1690     1690           
     Branches      283      283           
   =======================================
     Hits         1072     1072           
     Misses        618      618
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=)
 | `84.66% <ø> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=footer). 
Last update 
[ac2e1de...c3d24a9](https://codecov.io/gh/apache/cordova-ios/pull/344?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> SplashScreen dont handle iPhone X asset catalog image
> -----------------------------------------------------
>
>                 Key: CB-13290
>                 URL: https://issues.apache.org/jira/browse/CB-13290
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>    Affects Versions: cordova-ios 4.5.0
>            Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to