[
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218722#comment-16218722
]
ASF GitHub Bot commented on CB-13290:
-------------------------------------
Stefano1964 commented on a change in pull request #344: CB-13290: (ios) Update
splash screen mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146873474
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens,
splashScreensDir) {
{dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
{dest: 'Default-667h.png', width: 750, height: 1334},
{dest: 'Default-736h.png', width: 1242, height: 2208},
- {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+ {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+ {dest: 'Default-2436h.png', width: 1125, height: 2436},
+ {dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
Review comment:
There is support for iPhone X in asset catalog (LaunchImage), just check iOS
8 and later, but there is a bug in xCode 9 (seems to be fixed in 9.1) that
prevent to use LaunchImage for both portrait and landscape:
https://stackoverflow.com/questions/46263795/iphone-x-incorrect-launch-screen-orientation-used
I modified the splashscreen plugin to support iPhoneX and is working,
portrait only, for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SplashScreen dont handle iPhone X asset catalog image
> -----------------------------------------------------
>
> Key: CB-13290
> URL: https://issues.apache.org/jira/browse/CB-13290
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Affects Versions: cordova-ios 4.5.0
> Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
