[
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219487#comment-16219487
]
ASF GitHub Bot commented on CB-13290:
-------------------------------------
surajpindoria closed pull request #344: CB-13290: (ios) Update splash screen
mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
index 175f378c6..58735deb7 100644
---
a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
+++
b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
@@ -1,6 +1,24 @@
{
"images" : [
{
+ "extent": "full-screen",
+ "idiom": "iphone",
+ "subtype": "2436h",
+ "filename": "Default-2436h.png",
+ "minimum-system-version": "11.0",
+ "orientation": "portrait",
+ "scale": "3x"
+ },
+ {
+ "extent": "full-screen",
+ "idiom": "iphone",
+ "subtype": "2436h",
+ "filename": "Default-Landscape-2436h.png",
+ "minimum-system-version": "11.0",
+ "orientation": "landscape",
+ "scale": "3x"
+ },
+ {
"extent" : "full-screen",
"idiom" : "iphone",
"subtype" : "736h",
@@ -120,6 +138,7 @@
{
"orientation" : "landscape",
"idiom" : "ipad",
+ "filename": "Default-Landscape~ipad.png",
"extent" : "full-screen",
"scale" : "1x"
},
@@ -145,6 +164,7 @@
{
"orientation" : "landscape",
"idiom" : "ipad",
+ "filename": "Default-Landscape@2x~ipad.png",
"extent" : "full-screen",
"scale" : "2x"
}
@@ -153,4 +173,4 @@
"version" : 1,
"author" : "xcode"
}
-}
\ No newline at end of file
+}
diff --git a/bin/templates/scripts/cordova/lib/prepare.js
b/bin/templates/scripts/cordova/lib/prepare.js
index 33f318b97..de345dd55 100644
--- a/bin/templates/scripts/cordova/lib/prepare.js
+++ b/bin/templates/scripts/cordova/lib/prepare.js
@@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens,
splashScreensDir) {
{dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
{dest: 'Default-667h.png', width: 750, height: 1334},
{dest: 'Default-736h.png', width: 1242, height: 2208},
- {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+ {dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+ {dest: 'Default-2436h.png', width: 1125, height: 2436},
+ {dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
];
var pathMap = {};
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SplashScreen dont handle iPhone X asset catalog image
> -----------------------------------------------------
>
> Key: CB-13290
> URL: https://issues.apache.org/jira/browse/CB-13290
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Affects Versions: cordova-ios 4.5.0
> Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
