[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597175#comment-16597175
 ] 

ASF GitHub Bot commented on CB-7179:
------------------------------------

dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-417231572
 
 
   @christianliebel 
   > Does “shared cookie pool” mean that the IAB can share cookies with the 
WebView as well? 
   
   Yes, it uses the [CDVWKProcessPoolFactory 
class](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKProcessPoolFactory.m)
 from 
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
 in order to share cookies between the Cordova app Webview and the IAB Webview 
so setting a cookie in one makes it available in the other. This is currently 
enabled by default, but could be made optional.
   
   > Unfortunately, there are new merge conflicts…
   
   Since the master branch is being continually updated, this PR branch will 
undoubtedly get out of sync with it. But there's no point in me continually 
resolving merge conflicts if this PR is never going to be reviewed/merged.
   
   @shazron If `cordova-plugin-wkwebview-engine` is integrated into 
`cordova-ios@5`, maybe it would make sense to align this PR with 
`cordova-ios@5`?
   
   This would eliminate the need for the `__has_include` Objective-C macro 
which is used to detect the conditional presence of the 
`cordova-plugin-wkwebview-engine` classes in the build, but which only appears 
to work in the device environment so is currently causing the Travis CI build 
to fail due to tests failing in the Simulator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
>                 Key: CB-7179
>                 URL: https://issues.apache.org/jira/browse/CB-7179
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-plugin-inappbrowser
>         Environment: iOS 8
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to