[
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602127#comment-16602127
]
ASF GitHub Bot commented on CB-7179:
------------------------------------
dpa99c commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView
support for iOS
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214681185
##########
File path: README.md
##########
@@ -136,9 +136,10 @@ instance, or the system browser.
iOS supports these additional options:
+ - __usewkwebview__: set to `yes` to use WKWebView engine for the
InappBrowser. Omit or set to `no` (default) to use UIWebView. Note: this
requires that a WKWebView engine plugin be installed in the Cordova project
(e.g.
[cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
or
[cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
Review comment:
If `usewkwebview=yes` and no WKWebView plugin is installed, [the `loaderror`
callback will be
invoked](https://github.com/dpa99c/cordova-plugin-inappbrowser/blob/CB-7179/src/ios/CDVInAppBrowser.m#L48)
with the error message "usewkwebview option specified but
cordova-plugin-wkwebview-engine not present"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-plugin-inappbrowser
> Environment: iOS 8
> Reporter: Shazron Abdullah
> Priority: Major
>
> support dual use with UIWebView
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
