[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605736#comment-16605736
]
Oliver Salzburg commented on CB-14166:
--------------------------------------
That change is not valid. When you run `npm` on the CLI, you would get the
.exe. By introducing this change, you're introducing behavior that is
unexpected, because a different npm entry point is used. This is making things
worse. Especially when you're forcing the system to try to find a .cmd. It may
very well be a .bat for some reason.
The solution is still to properly escape when running commands on the shell,
and to not escape when not running on the shell. Proper abstractions will take
care of that for you.
In this scenario, the only problem is that part of the code (fetch.js) decides
that it already knows how the command is executed in the end, which it does
not. The additional escaping introduced in this place is a mistake. It needs to
be removed and superspawn needs to be taught how to properly escape, or, as I
have been saying continuously, it should be replaced with something that works
(cross-spawn, execa).
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
