[ 
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605744#comment-16605744
 ] 

Jan Piotrowski (Sujan) commented on CB-14166:
---------------------------------------------

That special handling the existing PR removes sure is there for a reason - a 
long time ago something was broken and this was the fix.
So removing it might this one current use case (using Nodist) work, but break 
other, unknown things at the same time.

The real solution for this is of course to properly fix _all_ of this by making 
sure that Cordova has a way to just tell _someone_ to run a specific command, 
and it is run on all platforms. But someone has to create that PR first for 
this to be an option ;)

Until then, maybe some special handling for Nodist (e.g. path includes 
"Nodist")? Super dirty, but quick and works and will be removed when the real 
rewrite comes in.

> Cordova on windows fails when adding plugin
> -------------------------------------------
>
>                 Key: CB-14166
>                 URL: https://issues.apache.org/jira/browse/CB-14166
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: takuya
>            Assignee: Jesse MacFadyen
>            Priority: Blocker
>         Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit 
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that 
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to