[
https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608432#comment-16608432
]
ASF GitHub Bot commented on CB-14166:
-------------------------------------
knight9999 commented on issue #688: CB-14166 distinguish npm.cmd and npm.exe in
win32 to check escape necessary
URL: https://github.com/apache/cordova-lib/pull/688#issuecomment-419711395
@raphinesse Thanks for your valuable comments.
I agree your suggestion to fix this issue basically.
Here I think this PR is only quick fix. Because improving cordova-common,
cordova-fetch
and changing cordova-lib to refer them seem to require rather long time.
Actually the cordova-lib
still refers to cordova-fetch 1.3.0 yet.
I hope that this PR should be removed after fundamental improvements of
cordova-common/cordova-fetch which just you pointed out are applied.
Even if this PR is not merged, this suggests the dirty and easy fix of
cordova-lib for each user.
If your new PR is coming soon, it is no problem to skip this PR, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova on windows fails when adding plugin
> -------------------------------------------
>
> Key: CB-14166
> URL: https://issues.apache.org/jira/browse/CB-14166
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: takuya
> Assignee: Jesse MacFadyen
> Priority: Blocker
> Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png
>
>
> cordova on windows fails to add the plugin.
> This error happens even when cordova-plugin-whitelist.
> Therefore `cordova platform add windows` also fails.
> For example,
> ```
> > cordova create sample
> > cd sample
> > cordova platform add windows
> ```
> brings following error.
> ```
> ...
> Check your connection and plugin name/version/URL.
> Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit
> code 1 Error output:
> npm ERR! code EINVALIDTAGNAME
> npm ERR! Invalid tag name ""1"": Tags may not have any characters that
> encodeURIComponent encodes.
> ```
> This error happens for windows environment only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
