[
https://issues.apache.org/jira/browse/CXF-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996443#comment-12996443
]
Colm O hEigeartaigh commented on CXF-3348:
------------------------------------------
Hi Alexey,
Thanks for the patch. A couple of points...
1) You need to tick the box assigning copyright to the ASF when submitting the
patch, or else we can't apply it.
2) Please make sure there are no tabs in patchfiles
3) I don't think your change to writing out the SecondaryParameters is the
right way to proceed. You've changed it so that the TokenType does not get
written out from the template element in SecondaryParameters, but instead it
saves the value and writes it out separately as an optional TokenType element.
I would prefer if we kept the existing behaviour, i.e. if there is a TokenType
in the template then just write it out as a SecondaryParameter. Otherwise, we
have a class variable which we set on the STSClient via e.g.
setTokenType(String), and we write that out instead as the optional element.
Make sense?
Colm.
> [cxf-rt-ws-security] Fix for TokenType support
> ------------------------------------------------
>
> Key: CXF-3348
> URL: https://issues.apache.org/jira/browse/CXF-3348
> Project: CXF
> Issue Type: Improvement
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Alexey Markevich
> Priority: Minor
> Labels: TokenType
> Attachments: fixed+TokenType+support.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This patch takes TokenType from template and put it into request. Also
> TokenType extracted from response and added to result value.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
