[ 
https://issues.apache.org/jira/browse/CXF-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997390#comment-12997390
 ] 

Colm O hEigeartaigh commented on CXF-3348:
------------------------------------------


Hi Alexey,

> optional TokenType element can be assigned using setter (in this case it will 
> be added to RequestSecurityToken);

Yes that's fine - but your patch removed the existing functionality, where the 
TokenType is set by parsing the Template element. One functionality should 
override the other, but both should work independently.

> set TokenType in createSecurityToken only if STS response contains it.

I'd like the token type to be set on the SecurityToken in all cases. So if the 
STS does not return a TokenType element, then set the token type to be whatever 
was sent to the STS.

Colm.

> [cxf-rt-ws-security] Fix for TokenType support  
> ------------------------------------------------
>
>                 Key: CXF-3348
>                 URL: https://issues.apache.org/jira/browse/CXF-3348
>             Project: CXF
>          Issue Type: Improvement
>          Components: WS-* Components
>    Affects Versions: 2.4
>            Reporter: Alexey Markevich
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>              Labels: TokenType
>         Attachments: Fix+for+TokenType+support.patch, 
> Fix+for+TokenType+support.patch, fixed+TokenType+support.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> This patch takes TokenType from template and put it into request. Also 
> TokenType extracted from response and added to result value.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to