[ 
https://issues.apache.org/jira/browse/CXF-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997338#comment-12997338
 ] 

Colm O hEigeartaigh commented on CXF-3348:
------------------------------------------

Hi Alexey,

The most recent patch still hasn't addressed my objection of:

"I don't think your change to writing out the SecondaryParameters is the right 
way to proceed. You've changed it so that the TokenType does not get written 
out from the template element in SecondaryParameters, but instead it saves the 
value and writes it out separately as an optional TokenType element. "

I want to preserve the existing behaviour of writing out the TokenType from the 
template element, unless the user sets the TokenType on the STSClient directly, 
in which case write that out. 

You've also removed the getKeySize() method...why?

Colm.

> [cxf-rt-ws-security] Fix for TokenType support  
> ------------------------------------------------
>
>                 Key: CXF-3348
>                 URL: https://issues.apache.org/jira/browse/CXF-3348
>             Project: CXF
>          Issue Type: Improvement
>          Components: WS-* Components
>    Affects Versions: 2.4
>            Reporter: Alexey Markevich
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>              Labels: TokenType
>         Attachments: Fix+for+TokenType+support.patch, 
> Fix+for+TokenType+support.patch, fixed+TokenType+support.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> This patch takes TokenType from template and put it into request. Also 
> TokenType extracted from response and added to result value.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to