[ 
https://issues.apache.org/jira/browse/CXF-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429832#comment-16429832
 ] 

Andriy Redko commented on CXF-7694:
-----------------------------------

[~ilgrosso] [~deki] Sorry for the delay guys. So I've looked into the 
differences between Swagger2 and OpenApi integration with respect to customizer 
usage. The *Swagger2Feature* always creates *Swagger2Customizer* instance and 
forceably sets the "*dynamicBasePath*" to "*true*" (irrespective what is set in 
the *Swagger2Customizer* instance). Whereas *OpenApiFeature* does not do that 
and uses the *OpenApiCustomizer* only when it is provided (the reason for that 
is that integration of the customizer into OpenApi is much more engaging than 
in Swagger2, if it could be avoided it would be better), as such accepting the 
customizer properties as is. Also, the difference at large is that there is no 
*basePath* property in the OpenApi v3.0 specification anymore, there are other 
means to inject this metadata into the specification (*servers* component). If 
you guys agree, I would prefer to keep it this way, at least the customization 
is now respected as-is, no altering from the *OpenApiFeature* side. What do you 
think?

> spring boot jax-rs sample creates incorrect urls in swagger
> -----------------------------------------------------------
>
>                 Key: CXF-7694
>                 URL: https://issues.apache.org/jira/browse/CXF-7694
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.2.4
>            Reporter: pre sto
>            Assignee: Dennis Kieselhorst
>            Priority: Minor
>             Fix For: 3.2.5
>
>
> The sample code in
> [https://github.com/apache/cxf/tree/master/distribution/src/main/release/samples/jax_rs/spring_boot]
> creates in swagger ui urls like
> [http://localhost:8080/sayHello/q]
> which do not work, instead of
> [http://localhost:8080/services/helloservice/sayHello/q|http://localhost:8080/services/helloservice/sayHello/]
> The problem started w. the commit of  "[[CXF-7634] changed Spring Boot sample 
> to use 
> OpenApiFeature|https://github.com/apache/cxf/commit/5b7308408d8b0127a5ee4deea7bd66b44217dd58]";
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to