[jira] [Commented] (DRILL-2818) Error message must be updated when query fails with FileNotFoundException

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634206#comment-14634206
 ] 

ASF GitHub Bot commented on DRILL-2818:
---------------------------------------

Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35053195
  
    --- Diff: 
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -44,31 +46,37 @@
     import com.google.common.collect.ImmutableList;
     import com.typesafe.config.Config;
     import com.typesafe.config.ConfigFactory;
    +import com.typesafe.config.ConfigRenderOptions;
     
     public final class DrillConfig extends NestedConfig{
    -//  private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(DrillConfig.class);
    +  private static final Logger logger = getLogger(DrillConfig.class);
    +
       private final ObjectMapper mapper;
       private final ImmutableList<String> startupArguments;
     
       public static final boolean ON_OSX = 
System.getProperty("os.name").contains("OS X");
     
    -  @SuppressWarnings("restriction")  private static final long 
MAX_DIRECT_MEMORY = sun.misc.VM.maxDirectMemory();
    +  @SuppressWarnings("restriction")
    +  private static final long MAX_DIRECT_MEMORY = 
sun.misc.VM.maxDirectMemory();
     
       @SuppressWarnings("unchecked")
       private volatile List<Queue<Object>> sinkQueues = new 
CopyOnWriteArrayList<Queue<Object>>(new Queue[1]);
     
       @VisibleForTesting
    -  public DrillConfig(Config config, boolean enableServer) {
    +  public DrillConfig(Config config, boolean enableServerConfigs) {
         super(config);
    -    logger.debug("Setting up config object.");
    +    logger.debug("Setting up DrillConfig object.");
    +    if (logger.isTraceEnabled()) {
    --- End diff --
    
    No, I didn't expect it to take any significant time; I just thought someone 
would object if the calls weren't guarded by that if statement.
    
    So ... remove it to reduce the clutter, or keep/leave it?


> Error message must be updated when query fails with FileNotFoundException
> -------------------------------------------------------------------------
>
>                 Key: DRILL-2818
>                 URL: https://issues.apache.org/jira/browse/DRILL-2818
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: SQL Parser
>    Affects Versions: 0.9.0
>         Environment: exception branch
>            Reporter: Abhishek Girish
>            Assignee: Deneche A. Hakim
>            Priority: Minor
>              Labels: error_message_must_fix
>             Fix For: 1.3.0
>
>
> When user specifies a non-existent file/directory in a query, the following 
> error is being thrown:
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: SYSTEM ERROR: Failure handling SQL.
> [9184097e-8339-42d3-96ce-1fba51c6bc78 on 192.168.158.107:31010]
> Error: exception while executing query: Failure while executing query. 
> (state=,code=0)
> {code}
> This should be updated to 
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: File /tmp/tpch does not exist. 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)