[
https://issues.apache.org/jira/browse/DRILL-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634214#comment-14634214
]
ASF GitHub Bot commented on DRILL-2818:
---------------------------------------
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35053589
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -115,19 +124,26 @@ public static DrillConfig forClient() {
* <p>
* Configuration values are retrieved as follows:
* <ul>
- * <li>Check a single copy of "drill-override.conf". If multiple copies
are on the classpath, behavior is
- * indeterminate. If a non-null value for overrideFileName is provided,
this is utilized instead of drill-override.conf.</li>
- * <li>Check all copies of "drill-module.conf". Loading order is
indeterminate.</li>
- * <li>Check a single copy of "drill-default.conf". If multiple copies
are on the classpath, behavior is
- * indeterminate.</li>
+ * <li>Check a single copy of "drill-override.conf". If multiple copies
are
+ * on the classpath, which copy is read is indeterminate.
+ * If a non-null value for overrideFileResourcePathname is provided,
this
+ * is used instead of "{@code drill-override.conf}".</li>
+ * <li>Check all copies of "{@code drill-module.conf}". Loading order is
+ * indeterminate.</li>
+ * <li>Check a single copy of "{@code drill-default.conf}". If multiple
+ * copies are on the classpath, which copy is read is
indeterminate.</li>
* </ul>
*
* </p>
- * @param overrideFileName The name of the file to use for override
purposes.
+ * @param overrideFileResourcePathname
+ * the classpath resource pathname of the file to use for
+ * configuration override purposes; {@code null} specifies to
use the
+ * default pathname ({@link CommonConstants.CONFIG_OVERRIDE})
+ * (<strong>not</strong> to not look for an override file at
all)
--- End diff --
Reworded.
> Error message must be updated when query fails with FileNotFoundException
> -------------------------------------------------------------------------
>
> Key: DRILL-2818
> URL: https://issues.apache.org/jira/browse/DRILL-2818
> Project: Apache Drill
> Issue Type: Bug
> Components: SQL Parser
> Affects Versions: 0.9.0
> Environment: exception branch
> Reporter: Abhishek Girish
> Assignee: Deneche A. Hakim
> Priority: Minor
> Labels: error_message_must_fix
> Fix For: 1.3.0
>
>
> When user specifies a non-existent file/directory in a query, the following
> error is being thrown:
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: SYSTEM ERROR: Failure handling SQL.
> [9184097e-8339-42d3-96ce-1fba51c6bc78 on 192.168.158.107:31010]
> Error: exception while executing query: Failure while executing query.
> (state=,code=0)
> {code}
> This should be updated to
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: File /tmp/tpch does not exist.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
