[
https://issues.apache.org/jira/browse/DRILL-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634239#comment-14634239
]
ASF GitHub Bot commented on DRILL-2818:
---------------------------------------
Github user dsbos commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r35054916
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -138,34 +154,83 @@ public static DrillConfig create(Properties
testConfigurations) {
return create(null, testConfigurations, true);
}
- public static DrillConfig create(String overrideFileName, boolean
enableServerConfigs) {
- return create(overrideFileName, null, enableServerConfigs);
+ /**
+ * ...
+ * @param overrideFileResourcePathname
+ * see {@link #create(String)}'s {@code
overrideFileResourcePathname}
+ */
+ public static DrillConfig create(String overrideFileResourcePathname,
boolean enableServerConfigs) {
+ return create(overrideFileResourcePathname, null, enableServerConfigs);
}
- private static DrillConfig create(String overrideFileName, Properties
overriderProps, boolean enableServerConfigs) {
- overrideFileName = overrideFileName == null ?
CommonConstants.CONFIG_OVERRIDE : overrideFileName;
-
- // first we load defaults.
+ /**
+ * ...
--- End diff --
[Reply via e-mail because I don't currently see this comment of yours on
the pull-request page.]
> > + /**
> > + * ...xx
> I haven't seen this convention before, but I assume this means that the
docs for similar methods suffice and don't need to be repeated here.
No, actually it was an attempt to indicate that I hadn't addressed the
method description (the part before the parameters), and not intended to mean
"otherwise same as above".
I was trying to quickly at least document the parameter (add the reference
to the other existing text) without taking time to fill in the whole
documentation comment.
Would simply leaving the method description part blank be better than using
"..."?
Daniel
Jason Altekruse wrote:
>
> In common/src/main/java/org/apache/drill/common/config/DrillConfig.java
<https://github.com/apache/drill/pull/93#discussion_r35042277>:
>
> > }
> >
> > - private static DrillConfig create(String overrideFileName,
Properties overriderProps, boolean enableServerConfigs) {
> > - overrideFileName = overrideFileName == null ?
CommonConstants.CONFIG_OVERRIDE : overrideFileName;
> > -
> > - // first we load defaults.
> > + /**
> > + * ...
>
> I haven't seen this convention before, but I assume this means that the
docs for similar methods suffice and don't need to be repeated here. I would
possibly recommend moving the longer comment above to here, in which case I
think it would be possible to just put "..." above all of the alternative
implementations of this method. I think it makes the most sense to put the
comment describing the general idea of the functions purpose above the version
that also describes what all of parameters can do.
>
> —
> Reply to this email directly or view it on GitHub
<https://github.com/apache/drill/pull/93/files#r35042277>.
>
--
Daniel Barclay
MapR Technologies
> Error message must be updated when query fails with FileNotFoundException
> -------------------------------------------------------------------------
>
> Key: DRILL-2818
> URL: https://issues.apache.org/jira/browse/DRILL-2818
> Project: Apache Drill
> Issue Type: Bug
> Components: SQL Parser
> Affects Versions: 0.9.0
> Environment: exception branch
> Reporter: Abhishek Girish
> Assignee: Deneche A. Hakim
> Priority: Minor
> Labels: error_message_must_fix
> Fix For: 1.3.0
>
>
> When user specifies a non-existent file/directory in a query, the following
> error is being thrown:
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: SYSTEM ERROR: Failure handling SQL.
> [9184097e-8339-42d3-96ce-1fba51c6bc78 on 192.168.158.107:31010]
> Error: exception while executing query: Failure while executing query.
> (state=,code=0)
> {code}
> This should be updated to
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: File /tmp/tpch does not exist.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
