[
https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646742#comment-14646742
]
ASF GitHub Bot commented on DRILL-3313:
---------------------------------------
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/81#discussion_r35810091
--- Diff:
exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java ---
@@ -119,29 +117,22 @@ public int getVarByteLength(){
@Override
public SerializedField getMetadata() {
return getMetadataBuilder() //
+ .addChild(offsetVector.getMetadata())
.setValueCount(getAccessor().getValueCount()) //
- .setVarByteLength(getVarByteLength()) //
+// .setVarByteLength(getVarByteLength()) //
--- End diff --
We should probably at least leave a comment as to why this was here
originally and why it was removed and/or may re-enabled at some point. That or
just remove it.
> Eliminate redundant #load methods and unit-test loading & exporting of vectors
> ------------------------------------------------------------------------------
>
> Key: DRILL-3313
> URL: https://issues.apache.org/jira/browse/DRILL-3313
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Data Types
> Affects Versions: 1.0.0
> Reporter: Hanifi Gunes
> Assignee: Jason Altekruse
> Fix For: 1.2.0
>
>
> Vectors have multiple #load methods that are used to populate data from raw
> buffers. It is relatively tough to reason, maintain and unit-test loading and
> exporting of data since there is many redundant code around load methods.
> This issue proposes to have single #load method conforming to VV#load(def,
> buffer) signature eliminating all other #load overrides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
