[
https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646745#comment-14646745
]
ASF GitHub Bot commented on DRILL-3313:
---------------------------------------
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/81#discussion_r35810323
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
@@ -177,9 +167,16 @@ public boolean copyFromSafe(int inIndex, int outIndex,
BitVector from) {
@Override
public void load(SerializedField metadata, DrillBuf buffer) {
- assert this.field.matches(metadata);
- int loaded = load(metadata.getValueCount(), buffer);
- assert metadata.getBufferLength() == loaded;
+ assert field.matches(metadata);
--- End diff --
If you decide to add this back in the case I mentioned above where it was
removed, it would probably be worth having them produce the same message when
the assert fails.
> Eliminate redundant #load methods and unit-test loading & exporting of vectors
> ------------------------------------------------------------------------------
>
> Key: DRILL-3313
> URL: https://issues.apache.org/jira/browse/DRILL-3313
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Data Types
> Affects Versions: 1.0.0
> Reporter: Hanifi Gunes
> Assignee: Jason Altekruse
> Fix For: 1.2.0
>
>
> Vectors have multiple #load methods that are used to populate data from raw
> buffers. It is relatively tough to reason, maintain and unit-test loading and
> exporting of data since there is many redundant code around load methods.
> This issue proposes to have single #load method conforming to VV#load(def,
> buffer) signature eliminating all other #load overrides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
