[
https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646752#comment-14646752
]
ASF GitHub Bot commented on DRILL-3313:
---------------------------------------
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/81#discussion_r35811005
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java
---
@@ -26,21 +25,8 @@
*
* @param valueCount Number of values in the vector.
*/
- public void allocateNew(int valueCount);
-
- /**
- * Load the records in the provided buffer based on the given number of
values.
- * @param valueCount Number of values the buffer contains.
- * @param buf Incoming buffer.
- * @return The number of bytes of the buffer that were consumed.
- */
- public int load(int valueCount, DrillBuf buf);
+ void allocateNew(int valueCount);
+ void zeroVector();
- public abstract Mutator getMutator();
-
- /**
- * Zero out the underlying buffer backing this vector.
--- End diff --
I think this comment should be left in.
> Eliminate redundant #load methods and unit-test loading & exporting of vectors
> ------------------------------------------------------------------------------
>
> Key: DRILL-3313
> URL: https://issues.apache.org/jira/browse/DRILL-3313
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Data Types
> Affects Versions: 1.0.0
> Reporter: Hanifi Gunes
> Assignee: Jason Altekruse
> Fix For: 1.2.0
>
>
> Vectors have multiple #load methods that are used to populate data from raw
> buffers. It is relatively tough to reason, maintain and unit-test loading and
> exporting of data since there is many redundant code around load methods.
> This issue proposes to have single #load method conforming to VV#load(def,
> buffer) signature eliminating all other #load overrides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
