[ 
https://issues.apache.org/jira/browse/DRILL-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271022#comment-15271022
 ] 

ASF GitHub Bot commented on DRILL-4654:
---------------------------------------

Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/pull/495#issuecomment-216937718
  
    We currently use multiple drillbits in the same JVM process for our unit 
tests, won't this cause them to conflict with one another? I don't know if 
production use cases try to run multiple Drillbits in a single JVM, but even if 
this isn't a use case, a stateful API like the metrics registry seems like the 
wrong thing to move more towards static shared API. While I know it is 
currently static, I think the idea with these methods you were deprecating is 
that we would try to move to not be accessing anything static.


> Expose New System Metrics
> -------------------------
>
>                 Key: DRILL-4654
>                 URL: https://issues.apache.org/jira/browse/DRILL-4654
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>             Fix For: 1.8.0
>
>
> + Add more metrics to the DrillMetrics registry (exposed through web UI and 
> jconsole, through JMX): pending queries, running queries, completed queries, 
> current memory usage (root allocator)
> + Clean up and document metric registration API
> + Deprecate getMetrics() method in contextual objects; use 
> DrillMetrics.getRegistry() directly
> + Make JMX reporting and log reporting configurable through system properties 
> (since config file is not meant to be used in common module)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to